Skip to content

Modify comments to point to Paul Stoffregen's Serial Flash library #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

noelpaz
Copy link
Contributor

@noelpaz noelpaz commented Mar 9, 2017

The current comments in the CurieSerialFlash examples has the library manager shortcut and the user will be downloading the versions 1.0 to 4.0, but these versions will not work with these examples and compilation fails. The user instead should be instructed to get the current working library version from github at https://github.com/PaulStoffregen/SerialFlash

@noelpaz noelpaz requested a review from eriknyquist March 9, 2017 01:40
@noelpaz
Copy link
Contributor Author

noelpaz commented Mar 9, 2017

@eriknyquist Please review. I am a bit confused at the white space additions. It could be my editor.

@noelpaz noelpaz added this to the Deneb milestone Mar 9, 2017
@noelpaz noelpaz force-pushed the serialflash_depends branch 2 times, most recently from f5a198d to a9c1e9c Compare March 9, 2017 03:27
@noelpaz noelpaz force-pushed the serialflash_depends branch from a9c1e9c to c90ef20 Compare March 9, 2017 03:38
@noelpaz
Copy link
Contributor Author

noelpaz commented Mar 9, 2017

@eriknyquist . My editor cleaned some of the whitespace it looks like. So I cleaned that up.

Copy link
Contributor

@eriknyquist eriknyquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noelpaz

@eriknyquist eriknyquist merged commit 76f7d75 into arduino:master Mar 9, 2017
@noelpaz noelpaz deleted the serialflash_depends branch March 21, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants