Skip to content

Moving shebang at the top of the file #9291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

endorama
Copy link
Contributor

@endorama endorama commented Oct 7, 2019

Shebang changes how Unix-like OS run scripts, ensuring the script is run with the specified interpreter. In this case as the line was not the first in the file, users without bash as their default shell would experience issues running the script.

Fixes #9281
More details on shebang usage here https://en.wikipedia.org/wiki/Shebang_(Unix)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Shebang changes how Unix-like OS run scripts, ensuring the script is run with the specified interpreter. In this case as the line was not the first in the file, users without bash as their default shell would experience issues running the script.

Fixes #9281
More details on shebang usage here https://en.wikipedia.org/wiki/Shebang_(Unix)
@facchinm
Copy link
Member

facchinm commented Oct 7, 2019

LGTM!

Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. I looked at the history, it seems that this shebang has been in the wrong place since the file was added.

@facchinm facchinm merged commit 0d9de02 into master Oct 10, 2019
@facchinm facchinm deleted the fix-arduino-linux-setup-shebang branch October 10, 2019 07:33
@cmaglie cmaglie added this to the Release 1.8.11 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in arduino-linux-setup.sh affecting non-bash users
4 participants