Skip to content

Buttons in managers #9167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

joew46167
Copy link

Fix for issue #9166 - set model to false before closing the dialog box so that focus returns properly.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

@joew46167
Copy link
Author

I feel like maybe I should have used a new branch for this :(

Let me know if I need to close this PR and create a new one from a new branch.

@facchinm
Copy link
Member

Don't worry, I'm cherry-picking the relevant commit and applying on the tree

@facchinm
Copy link
Member

Merged as b9c3f00

@facchinm facchinm closed this Aug 26, 2019
@cmaglie cmaglie added this to the Release 1.8.11 milestone Jan 22, 2020
@per1234 per1234 added accessibility Enabling the use of the software by everyone Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface labels Oct 30, 2021
@per1234 per1234 added the Type: Duplicate Another item already exists for this topic label Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Enabling the use of the software by everyone Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface Type: Duplicate Another item already exists for this topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants