Skip to content

Add in accessibility support for screen readers in board and library managers #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

joew46167
Copy link

@joew46167 joew46167 commented Aug 15, 2019

ContributedLibraryTableCellJPanel.java: Add description to accessibility context
ContributedPlatformTableCellJPanel.java: Add description to accessibility context

ProgressJProgressBar.java:
Add status to accessibility context
make progress bar focusable so screen reader can access

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

   ContributedLibraryTableCellJPanel.java: Add description to accessibility context
   ContributedPlatformTableCellJPanel.java: Add description to accessibility context

   ProgressJProgressBar.java:
      Add status to accessibility context
      make progress bar focusable so screen reader can access
@joew46167
Copy link
Author

I clicked Have you written new tests for your core changes, as applicable? but imo it isn't applicable.

@facchinm
Copy link
Member

Hi @joew46167 ,
the PR looks fine! Did you have the chance to test it manually with a screen reader? In which platform?
I'm going to merge it immediately to get a broader audience to test it and eventually we can amend it later

@facchinm facchinm merged commit c3fdb10 into arduino:master Aug 19, 2019
@joew46167
Copy link
Author

Hi @facchinm

I tested on Windows using NVDA. Ken Perry also tested with

@cmaglie cmaglie added this to the Release 1.8.11 milestone Jan 22, 2020
@per1234 per1234 added accessibility Enabling the use of the software by everyone Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Enabling the use of the software by everyone Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants