Skip to content

Replace hardcoded pin numbers with variables #9099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

jordy-u
Copy link

@jordy-u jordy-u commented Jul 25, 2019

Replace pin numbers "A0" and "A1" with variables "xAxis" and "yAxis".

Variables "xAxis" and "yAxis" were created, but never used. I changed the hardcoded pin numbers to these variables to avoid confusion and to make the code more consistent.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Replace pin numbers "A0" and "A1" with variables "xAxis" and "yAxis".

Variables "xAxis" and "yAxis" were created, but never used. I changed the hardcoded pin numbers to these variables to avoid confusion and to make the code more consistent.
@facchinm
Copy link
Member

LGTM! Merging, thanks for the contribution!

@facchinm facchinm merged commit ddb0497 into arduino:ide-1.9.x-beta Jul 26, 2019
@cmaglie cmaglie added this to the Release 1.8.11 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants