Skip to content

Fix log path when you run ant run #9093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

mattiabertorello
Copy link
Contributor

When the IDE was started with ant run the log folder was wrong due to a premature initialization of the logging environment before set the log directory path.

@cmaglie
Copy link
Member

cmaglie commented Aug 1, 2019

I've cherry-picked the first two commits but still not working for me, it still creates the ${sys:log4j.dir}.

@mattiabertorello
Copy link
Contributor Author

The last two commits fix the problem this is the line that must delete it 9dd4c73#diff-6ccded341b7bbb710383be5a14f6529aL63

To address better this problem you need to refactor the setting folder path generation in a way that can be used in the custom configuration of log4j https://logging.apache.org/log4j/2.x/manual/customconfig.html

@cmaglie
Copy link
Member

cmaglie commented Aug 2, 2019

Ah now I see, that's the reason why you also extracted BoardCloudResolver! it wasn't clear at a first sight they looked more like two unrelated changes, this is the kind of things that it's worth explaining it in the commit message.

@mattiabertorello
Copy link
Contributor Author

Yes you are right, I should put in commit message

@cmaglie cmaglie merged commit 01d3d02 into arduino:master Aug 2, 2019
@cmaglie cmaglie added this to the Release 1.8.10 milestone Aug 2, 2019
@cmaglie cmaglie deleted the fix-log-path branch August 23, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants