Skip to content

Made the Mangler file compile again #8054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Conversation

lemio
Copy link
Contributor

@lemio lemio commented Oct 4, 2018

Mangler is the example file included in the IDE for developers that want to make their own tool. This mangler.java file is way outdated and didn't compile on the recent Arduino IDE pde.jar and arduino-core.jar

The .getCurrentTab() was missing, and for some reason it wouldn't compile with the isSelectionActive() , while I did find the file in https://github.com/arduino/Arduino/blob/master/app/src/processing/app/syntax/SketchTextArea.java . But at least people can compile it after these changes

src\Mangler.java:84: error: cannot find symbol
    if (editor.getCurrentTab().isSelectionActive()) {
                              ^
  symbol:   method isSelectionActive()
  location: class EditorTab
1 error
src\Mangler.java:73: error: cannot find symbol
      String selection = editor.getSelectedText();
                               ^
  symbol:   method getSelectedText()
  location: variable editor of type Editor
src\Mangler.java:86: error: cannot find symbol
      editor.setSelectedText(new String(stuff));
            ^
  symbol:   method setSelectedText(String)
  location: variable editor of type Editor
2 errors

The .getCurrentTab() was missing, and for some reason it wouldn't compile with the isSelectionActive() , while I did find the file in https://github.com/arduino/Arduino/blob/master/app/src/processing/app/syntax/SketchTextArea.java . But at least people can compile it after these changes
@cmaglie cmaglie merged commit 799879e into arduino:master Nov 5, 2018
@cmaglie cmaglie added this to the Release 1.8.8 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants