Symlink the arduino binary

[2E0PGS]

install.sh should symlink arduino into /usr/local/bin/arduino so arduino is accessible via users PATH.

Related issues:

#5780

#5366

[facchinm]

@2E0PGS this would make the "installation" dependant on sudo, which I would avoid at all costs.
Maybe checking the UID and then symlinking the executable in /usr/local/bin/ if we have permissions to do it could be a good solution.
This way, launching ./install.sh as a user wouldn't install the symlink, while sudo ./install.sh would.

[2E0PGS]

./install.sh would prompt for a password once it hits the symlink part if ran as non root currently. ⁣Peter Stevenson (2E0PGS) http://www.m3pgs.co.uk​

…

On 16 May 2018, 09:34, at 09:34, Martino Facchin ***@***.***> wrote: @2E0PGS this would make the "installation" dependant on `sudo`, which I would avoid at all costs. Maybe checking the UID and then symlinking the executable in `/usr/local/bin/` if we have permissions to do it could be a good solution. This way, launching `./install.sh` as a user wouldn't install the symlink, while `sudo ./install.sh` would. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #7593 (comment)

[facchinm]

Yes, but you are assuming that a system has sudo installed and that the user wants to launch arduino from the cli. Also, a per-user installation becomes impossible.

[2E0PGS]

OK I suppose I assumed they are in the SUDOers group. Ref want to access it from CLI I think most who install software expect to find it in path. Thats the easy way to launch software besides using menu entries.

How about making the whole script require root level privileges and then I add code to move the folder into /opt/ and generate symlink to usr/bin. That to me seems like a more sensible trend of installers.

Could add flags for user level install and system wide installs. one requiring root and one not.

[bengtmartensson]

Here is another suggestion: Just try to symlink; if it fails, handle it gracefully and tell the user. (More robust than "check if xxx and if so then zzz", and does not require root access.)

if ln -s xxxx /usr/local/bin/arduino ; then
else
    echo "Linking failed, hope that is OK. If not, redo as root/with sudo."
fi

[2E0PGS]

Yea that's a good idea.

[facchinm]

waiting for integration of #7593 (comment)

[2E0PGS]

I will add the changes ASAP.

[2E0PGS]

Added the suggested changes.

[2E0PGS]

Did anything like this ever get implemented? I am about to install Arduino and this pull never got merged so wonder if I need to manually symlink still...

[2E0PGS]

I did indeed have to symlink it manually still or use my branch.

I think this is fine for merge if the error message from rm or ln is ok in addition to the custom one. Otherwise I will need to modify this pull request so it only shows our custom error message if they don't run using sudo.