Skip to content

Let serial monitor send newline by default #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

matthijskooijman
Copy link
Collaborator

The serial.line_ending value was not present in the default
preferences file, so the default was implicitly 0, meaning "No line
ending". Since users often do not realize that they can even choose a
line ending, and "no line ending" is only rarely useful, it seems better
to default to sending a newline. Using both CR & NL would be more
consistent with Stream.println on the Arduino side, but just sending a
newline is probably easier to parse on the Arduino side.

The serial.line_ending value was not present in the default
preferences file, so the default was implicitly 0, meaning "No line
ending". Since users often do not realize that they can even choose a
line ending, and "no line ending" is only rarely useful, it seems better
to default to sending a newline. Using both CR & NL would be more
consistent with Stream.println on the Arduino side, but just sending a
newline is probably easier to parse on the Arduino side.
@matthijskooijman matthijskooijman added Component: IDE The Arduino IDE Component: IDE Serial monitor Tools > Serial Monitor feature request A request to make an enhancement (not a bug fix) labels Dec 16, 2017
@matthijskooijman
Copy link
Collaborator Author

@cmaglie @facchinm, would you consider merging this PR? It's fairly simple, but offers a nice improvement for new users.

@facchinm
Copy link
Member

Mmmhh, this is funny... The patch is already merged in master 🙂 as 98bd18e . Not sure why github is still allowing the merge. May I close it?

@matthijskooijman
Copy link
Collaborator Author

Ah, that's probably a manual cherry-pick or rebase. I think github only detects manual merges if you push the exact same commit, not a rebased version of it. Great, so it's merged already, I'll close this one then.

@matthijskooijman matthijskooijman deleted the default-newline branch May 28, 2018 14:27
@cmaglie cmaglie added this to the Release 1.8.6 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE Serial monitor Tools > Serial Monitor Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants