added setRowOffsets to liquid crystal library #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue#505 protocl bug, fixed NOT TESTED, issue#543 Epprom WRite, fixed NOT TESTED, issue arduino#544, partially fixed, needs more work
This was referenced Dec 18, 2013
Closed
cmaglie
added
feature request
|
The liquidcrystal improvements have been re-implemented in a more generic way in #1748, so I'll close this issue. I'm not sure if the watchdog commit was intended for here (commit looks too big to me as well) - if it's still relevant, please resubmit it in separate PR. |
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
fix clear routing table data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several LCD displays that have different internal memory foot prints than the standard library supports. For example, the normal row offsets are {0x00, 0x40, 0x14, 0x54}, other displays need different offsets such as { 0x00, 0x40, 0x10, 0x50 };
This change keeps the default the way it is and adds a method setRowOffsets which is called as follows
No impact on existing code and it simply moves the array definition from the setCursor function into the class definition.