-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add all analog references supported by the ATtinyX5 series #5300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mischnic thanks for submitting. The changes look good to me testing with the following sketch (based on the AnalogInput example):
Here are the sketch size differences:
Without the additional call to @cmaglie @facchinm @matthijskooijman any opinions on the extra code size? We could wrap the change in |
I'd personally avoid to change the ADMUX line for all targets, since the same can be accomplished with saner Something like
and
|
Add all analog references supported by the ATtinyX5 series
@mischnic thank you! |
Now it should possible to use the 2.56V voltage reference on the ATtinyX5's.
Should resolve #1739 , where the formula is derived from.