Skip to content

LiquidCrystal: One bugfix in setCursor and change all atributes from private to protected #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

LiquidCrystal: One bugfix in setCursor and change all atributes from private to protected #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee36551
Change private to protected allows to create derivated classes with c…
netmaniac Jul 28, 2011
4baf33b
Fix for case when row is 4 - then setCursor would access row_offsets[4]
netmaniac Jul 28, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/LiquidCrystal/LiquidCrystal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ void LiquidCrystal::home()
void LiquidCrystal::setCursor(uint8_t col, uint8_t row)
{
int row_offsets[] = { 0x00, 0x40, 0x14, 0x54 };
if ( row > _numlines ) {
if ( row >= _numlines ) {
row = _numlines-1; // we count rows starting w/0
}

Expand Down
2 changes: 1 addition & 1 deletion libraries/LiquidCrystal/LiquidCrystal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class LiquidCrystal : public Print {
void setCursor(uint8_t, uint8_t);
virtual void write(uint8_t);
void command(uint8_t);
private:
protected:
void send(uint8_t, uint8_t);
void write4bits(uint8_t);
void write8bits(uint8_t);
Expand Down