Skip to content

Add extra build symbols and recipe #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add extra build symbols and recipe #3085

wants to merge 2 commits into from

Conversation

PaulStoffregen
Copy link
Contributor

These are extra features needed to build the Teensy core library. They might be useful for others too? At the very least, this stuff should not cause any issues with boards not using these features.

@ArduinoBot
Copy link
Contributor

Build successful. Please test this code using one of the following:
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3085-BUILD-264-linux32.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3085-BUILD-264-linux64.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3085-BUILD-264-windows.zip
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3085-BUILD-264-macosx.zip

@matthijskooijman
Copy link
Collaborator

I added two minor nitpicks, but overall these look like simple and acceptable changes to me.

@PaulStoffregen
Copy link
Contributor Author

Sure, the names could be changed if anyone feels really strongly. I'll just have to go back and re-edit my patches in 1.6.1 and 1.6.3 with whatever the new names end up being.

@cmaglie cmaglie added Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix) Component: Compilation Related to compilation of Arduino sketches labels May 6, 2015
@ffissore ffissore self-assigned this May 7, 2015
@ffissore
Copy link
Contributor

I'm going to merge this, but a better long term solution to this kind of toolchain needs is to provide hooks between the official phases. We already have hooks.prebuild and hooks.postbuild, we need others such as hooks.sketch.prebuild, hooks.linker.postlink and so on

@ffissore ffissore mentioned this pull request May 26, 2015
Merged
@ffissore
Copy link
Contributor

@PaulStoffregen Please take a look at #3236 I've cherry-picked your first commit and added one that spread hooks all over the build process. Your build.elfpatch recipe could then become recipe.hooks.linking.postlink.0.pattern and in case you needed one more, you'd just add a recipe.hooks.linking.postlink.1.pattern

@ffissore
Copy link
Contributor

Last comment came a bit out of the blue: me and @cmaglie had a quick chat and agreed in implementing a generic solution rather that adding a specific build step with a specific semantic that may not fit others needs

@ffissore ffissore added this to the Release 1.6.5 milestone May 26, 2015
@ffissore ffissore modified the milestones: Release 1.6.5, Release 1.6.6 Jun 15, 2015
@ffissore
Copy link
Contributor

Closing as superseded by #3236. Please convert your additional recipes to hooks. You can find some docs here https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5-3rd-party-Hardware-specification#pre-and-post-build-hooks-since-ide-165

@ffissore ffissore closed this Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ffissore ffissore

Labels
Component: Compilation Related to compilation of Arduino sketches Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Milestone
Release 1.6.6
Development

Successfully merging this pull request may close these issues.
5 participants
@PaulStoffregen @ArduinoBot @matthijskooijman @ffissore @cmaglie