GSM Library fix for Galileo #2605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NONE state is renamed GSM_NONE When in Intel, the SoftwareSerial is not used, but Serial1 is called. checkModemInput is included and executed to look for modem comms. manageResponse gets a void implementation, so it compiles. GSM3ShieldV1DataNetworkProvider::inet_aton uses an intermediate value to generate the IP address
ffissore
added
the
Library: Other
| if(mgr) | ||
| mgr->manageMsg(thisHead, cb.getTail()); | ||
| } | ||
| else if(d==10) |
There was a problem hiding this comment.
why is this needed? (multiple mgr->manageMsg(thisHead, cb.getTail()); )
|
Hi @zorzano , first of all thanks for the submission; however there are some issues to address before merging this patch.
If you could rebase your patch and push force over this branch (or create another PR) I'll be happy to review and eventually merge it! |
facchinm
added
the
Waiting for feedback
facchinm
changed the title
|
Closing for lack of feedback. Reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted so the same library runs for Galileo. Tested also on 1.0.6 and 1.5.8.
NONE state is renamed GSM_NONE
When in Intel, the SoftwareSerial is not used, but Serial1 is called.
checkModemInput is included and executed to look for modem comms.
manageResponse gets a void implementation, so it compiles.
GSM3ShieldV1DataNetworkProvider::inet_aton uses an intermediate value to generate the IP address
A small change in WebClient that makes for us easier the automatic testing.