Skip to content

add save when verifyng and uploading #1934 #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fulvioieva
Copy link

this pull close #1934

@cmaglie cmaglie added this to the Release 1.5.8 milestone Aug 25, 2014
@ffissore
Copy link
Contributor

@ArduinoBot build this please

@matthijskooijman matthijskooijman added Component: IDE user interface The Arduino IDE's user interface Component: IDE The Arduino IDE Version: 1.5.x Waiting for feedback More information must be provided before we can proceed and removed Component: IDE user interface The Arduino IDE's user interface labels Sep 11, 2014
@cmaglie cmaglie modified the milestones: Release 1.5.9, Release 1.5.8 Oct 7, 2014
@GregWoods
Copy link

My apologies if this is the wrong place for this, but I feel strongly about the importance of this feature.

As an end user of the IDE, I'm baffled as to why this setting isn't default. Every other IDE I've used saves upon compiling. It may be the case that other IDEs had to save before compiling, and it's kind of neat in a technical kind of way that the Arduino IDE doesn't have to save first. But from an end user perspective it makes no sense.

Modern UIs should be moving away from the entire idea of 'save' - which was born out of necessity in the days when hard disks were monumentally slow. Now with large memory caches and fast disks, we should be designing apps to save constantly. How often do you see 'Save' in a tablet or phone app? Hopefully never.

For those that hate this idea, it's could be because your workflow is all wrong. We have Undo now, and have for quite a number of years. We are all using version control locally? So saving only at specific milestones, if and when you remember is not the way to work.

OK, I've digressed a little. This change doesn't go as far as I'd like, but it's a start. Please, please add it to the 1.5.8 release... preferably as a default... but I'll take what I can get :)

@cmaglie
Copy link
Member

cmaglie commented Oct 10, 2014

Hi @GregWoods

a cloud-like automatic save needs the undo-redo history to be preserved after closing the IDE (and saved with the sketch maybe?). In principle I agree with you, but in practice your suggestion requires a certain amount of work to be done.

In the meantime, to give you what you can get as soon as possible :-), you may try one of the builds here:
#2214 (comment)

those are test builds that have the auto-save feature implemented. Your feedback would be highly appreciated and eventually accelerate the adoption in the next release.

@GregWoods
Copy link

@cmaglie - Thanks for taking the time to reply. I've already installed and used the test build. So far so good. I'm glad to see that save on verify is ON by default.

@agdl
Copy link
Member

agdl commented Oct 31, 2014

Hi @fulvioieva . Your feature is good, but you have to write it in the way that if the file is in read only (example) it has to fail in a transparent way otherwise every time you modify it and click on verify or upload the message: the file is in read only.. and so only is displayed and this isn't very funny!

@GregWoods
Copy link

@agdl First, the file should only save if it has changed. If it is trying to save an unchanged file, then this is a bug (sorry, I haven't tested this behaviour yet).
Also, if you have changed a file, you obviously intend to work on it, so you need to make sure it isn't read only - it's a matter of using sensible working practices.

@agdl
Copy link
Member

agdl commented Nov 3, 2014

@GregWoods my observation is based on the fact that very often I (and I think many others) start to write my sketches starting from an example (that are read only) and I save my work when it works reasonably; testing it on the board. To do so I have to make many uploads so every time the message will appear. You can say: well save your work so you don't have problem. But I think that a check on the file (if it is read only -> don't save) is a better solution. This is my opinion i don't want to diminish your work!

@GregWoods
Copy link

@agdl Playing with the samples is a good case for verifying/uploading without saving. In this case you are correct... the popup message is too intrusive. It should be reserved for a manual save. It should however be made very clear in some other way that the file is read only - maybe space on the bottom status bar can be used.
Personally I find that it only takes a few minutes of playing with a sample before I want to save my own copy somewhere else. But for quick tests such as changing a PIN number and running the sample, the popup is too much.

@cmaglie
Copy link
Member

cmaglie commented Nov 9, 2014

All suggestions have been implemented on #2433, please follow up there.

@cmaglie cmaglie closed this Nov 9, 2014
@cmaglie cmaglie mentioned this pull request Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE Waiting for feedback More information must be provided before we can proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants