Feature/search and replace improved dialog

[eried]

No description provided.

[cmaglie]

hi @eried,

It looks good overall, just two things:

• It seems that the "Find:" textbox is auto filled with the editor's selected text only once while I'm used to have the textbox always filled, regardless of its previous state.
• The labels of the various checkbox are truncated:
  
  is it possible to enlarge the dialog so the label are fully displayed? Or maybe is better to move the third checkbox on the next row?

Finally, just a cosmetic request, it seems that the indentation is screwed up:
https://github.com/arduino/Arduino/pull/2070/files#diff-94f74f8f3930691cc9312c842909d7c7R358
maybe you have the tab set to 2 spaces?

[eried]

The first thing is to keep the original behavior (about not touching the Find field if there is something, since the dialog is not re-instantiated) it is easy to change but I am not sure if should work replacing always the find field (only when is empty because convenience for the user?)

About the layout it seems it works different in your system: http://content.screencast.com/users/erwinried/folders/Jing/media/b20a6ebe-4f84-48f4-9457-6a087d9c468a/2012-09-24_1627.png I will check if there is some autoadjust (or autoellipsis in these controls)

Can you tell me an example of the tab problem? Just a little piece of code with find and replace values where the tabulation is messed up?

[cmaglie]

Hey @eried,

thanks for the follow up.

Well, my experience with (almost) every other editor is that:

• if a text is selected then when I open the Find/Replace dialog the selection is always copied into the search field.
• if there is no text selected then when I open the Find/Replace dialog the search field keeps its latest value, unchanged.

I'd like to reproduce this behaviour, even if differs from the current one.

About the ellipses, the font is definitely bigger on my Linux system, I don't know what's the best way to handle this. Auto-resizing the dialog, as you suggested, seems a good way but I have the feeling that moving the checkbox on the next row could be simpler. BTW either solutions are good to me.

For the indentation, look the following URL:

https://github.com/arduino/Arduino/pull/2070/files#diff-94f74f8f3930691cc9312c842909d7c7R358

line 358 shows an indent that is far bigger than two spaces. Instead line 396 is wrong:

https://github.com/arduino/Arduino/pull/2070/files#diff-94f74f8f3930691cc9312c842909d7c7R396

I suppose that you used tabs instead of spaces with tabulation set to "2", so in your editor looks fine but it gets screwed up in github.

[eried]

Really cool! 👍