Replace_startMillis from Stream.h with local variables

[cider101]

The member _startMillis in the class Stream is unneccesarry and can be replace with a local variable within the methods timedRead() and timedPeek(). This saves 4bytes per Stream instance...

timedPeek() {
   unsigned long start = millis();
   int c = peek();
    while(c < 0 && millis() - start < timout) {
      c = peek();
    }
    return c; 
 }

I guess, the implemenation above should produce less code then the original one with the do-while-loop. At least, i find it more readable.

Also, timedRead() could be implemented using timedPeek()

timedRead() {
    return timedPeek() < 0 ? -1 : read();
}

This again, should produce less code - At least, it removes doublicated code...

[matthijskooijman]

Hmm, seems this pullrequest didn't work out: there's unrelated commits in the pullrequest and I don't see any commit in there from you? Perhaps you should read up on how pullrequest work? :-)

Also, see my last comment on #1918 (and when you do add a proper commit to a pullrequest, use the text "Closes #1918" anywhere in the commit message to let github automatically close the issue when the code is merged).

Finally, I like your idea of implementing timedRead with timedPeek(), it looks good to me.

[matthijskooijman]

If you need more help with the pullrequest or code, feel free to drop by in #arduino on the Freenode IRC network. I'm called blathijs there :-)

[cider101]

Perhaps you should read up on how pullrequest work? :-)

well, looks like that ;) Do i need to commit/checkin modified code first to create a pull request ?

[matthijskooijman]

Yes, see for example: http://yangsu.github.io/pull-request-tutorial/ (though note that it seems that tutorial just creates a new branch and pushes it out, but doesn't show actually adding commits to that new branch).

Reading up on git in general might also be useful, since I get the idea that you haven't worked with that either.

[cider101]

fixed the zero-timeout issue... now it should behave as before and as one would guess with a zero timeout...

timedPeek() {
   unsigned long start = millis();
   int c = peek();
    while(c < 0 && millis() - start < timout) {
      c = peek();
    }
    return c; 
}

or even more compact (but less readable)

timedPeek() {
   unsigned long start = millis();
   int c;
   while((c = peek()) < 0 && (millis() - start < timout));
   return c; 
}

next thing is reading the tutorial on the pull-request ;)