Great work #1913
Closed
Great work #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…running the IDE from the command line Eg: --board arduino:avr:pro:cpu=8MHzatmega168,other=value Closes arduino#1353
…flicting with files in IDE install location
… see: arduino#223 It now also parses PID and VID values with text afterwards properly
Can now detect devices with serial number in the port number on OSX
Added VID and PID for older Arduino Unos
…PrePreprocess.strip. Fixes arduino#817
…nt result. Updating test
Conflicts: libraries/Ethernet/examples/XivelyClient/XivelyClient.ino libraries/Ethernet/examples/XivelyClientString/XivelyClientString.ino libraries/GSM/examples/GSMXivelyClient/GSMXivelyClient.ino libraries/GSM/examples/GSMXivelyClientString/GSMXivelyClientString.ino libraries/Servo/examples/Knob/Knob.ino libraries/Servo/examples/Sweep/Sweep.ino libraries/WiFi/examples/WiFiXivelyClient/WiFiXivelyClient.ino libraries/WiFi/examples/WiFiXivelyClientString/WiFiXivelyClientString.ino
Conflicts: app/src/processing/app/Base.java
This was already fixed for HardwareSerial.cpp in arduino#1863, but there was one more case hidden in HardwareSerial_private.h. The index attributes have been uint8_t for a while, so there is no point in using int for local variables. This should allow the compiler to generate slightly more efficient code, but (at least on gcc 4.8.2) it also confuses the register allocator, causing this change to increase code size by 2 bytes instead due to extra push/pop instructions (but this will probably change in the future if the compiler improves).
…every time we build the IDE. This is particularly nice when working offline
Don't try to fetch astyle/jre on each build.
The code used to say: while (EFC0->EEFC_FSR & EEFC_FSR_FRDY == 0); This triggered a compiler warning, which is why I looked at this line more closely: warning: suggest parentheses around comparison in operand of '&' As the warning indicates, because the == operator has higher precedence than the & operator, the compiler is interpreting this line as: while (EFC0->EEFC_FSR & (EEFC_FSR_FRDY == 0)); Since EEFC_FSR_FRDY is defined as 1, (EEFC_FSR_FRDY == 0) is always false (== 0) and this reduces to: while (EFC0->EEFC_FSR & 0); Which reduces to: while (0); So effectively this line is a no-op. This commit adds parenthesis to restore the intended behaviour.
…l-int In HardwareSerial::_rx_complete_irq, don't use int for buffer index
JSSC, on unix based systems like linux and MacOSX, when listing serial ports tries to open each port to ensure its existence. While this check works well for linux ports /dev/ttyS0..31, it leads to unexpected behaviuors on MacOSX in particular with USB-CDC virtual serial ports. This patch disable the check and keep it enabled only for linux ttySxx ports. This adds also tty.* and cu.* to the list of available serial ports on MacOSX.
…as they require a different approach and have a different history
Fixes for 1.5.6-r2 release
…8.1' into xmegaduino-with-avr-toolchain-gcc-4.8.1
|
Wrong pull request. It contains months of commits and is lacking a description of the proposed feature. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.