Skip to content

LiquidCrystal improvements (support 16x4 displays) #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 5, 2014
Merged

LiquidCrystal improvements (support 16x4 displays) #1748

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
03a6b2c
Added setRowOffsets to LiquidCrystal library
msproul Dec 4, 2011
3fdda81
Make the LiquidCrystal row offsets uint8_t instead of int
matthijskooijman Dec 18, 2013
1786716
In LiquidCrystal::setCursor(), check against length of _row_offsets a…
matthijskooijman Dec 18, 2013
265ac7b
Support more LiquidCrystal displays out of the box
matthijskooijman Dec 18, 2013
8c6bcf0
In LiquidCrystal::begin(), use a define instead of a hardcoded 0
matthijskooijman Dec 18, 2013
9552db3
In LiquidCrystal, remove an unused variable
matthijskooijman Dec 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the LiquidCrystal row offsets uint8_t instead of int 
Since these are memory addresses, there is no need to make them signed.
Furthermore, the HD44780 chip supports memory addresses up to 0x67, so
uint8_t shouldbe sufficient.
  • Loading branch information
@matthijskooijman
matthijskooijman committed Dec 18, 2013
commit 3fdda81a1ad2b10b924866645d7b7eee2398a122
2 changes: 1 addition & 1 deletion libraries/LiquidCrystal/src/LiquidCrystal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class LiquidCrystal : public Print {
uint8_t _initialized;

uint8_t _numlines,_currline;
int _row_offsets[4];
uint8_t _row_offsets[4];
};

#endif