Incorrect handling of radio module `PWRON` pin in `SIGFOXClass::end()`

[alvdiaju]

I think the SIGFOXClass::end() routine have some issues. See the commented lines for details:

void SIGFOXClass::end()
{
  //Commented. I think its not right to assing LOW as a PIN-MODE
  //pinMode(poweron_pin, LOW);
  //delay(1);
  digitalWrite(chip_select_pin, LOW);
  delay(1);
  spi_port->beginTransaction(SPICONFIG);
  spi_port->transfer(0x05);
  spi_port->endTransaction();
  delay(1);
  digitalWrite(chip_select_pin, HIGH);
  //Added to switch off power supply to Sigfox module
  delay(1);
  digitalWrite(poweron_pin, LOW);
}

[facchinm]

Hi @alvdiaju ,
you are right indeed! Sorry for the late response; would you mind to submit a pull request with the patch? thanks!

[alvdiaju]

Hi facchinm,
I submitted the pull request. I hope to have done it well. Its my firts time participating in Github. I created the branch alvdiaju with the pull request.
Thank you :)

[per1234]

Hi @alvdiaju. Thanks for your report.

I see we never received your pull request: https://github.com/arduino-libraries/SigFox/pulls?q=is%3Apr+author%3Aalvdiaju

The commit is there in your fork though:
alvdiaju@3a6ab9c

Please submit the pull request.

If you have any questions, just let me know.