Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about NO_ETHERNET_TURN_OFF #8

Merged
merged 2 commits into from
May 13, 2024
Merged

Add warning about NO_ETHERNET_TURN_OFF #8

merged 2 commits into from
May 13, 2024

Conversation

alrvid
Copy link
Member

@alrvid alrvid commented May 13, 2024

Adds a warning that improper use of this #define can damage the Ethernet transmission termination resistors.

Adds a warning that improper use of this #define can damage the Ethernet transmission termination resistors.
@alrvid alrvid requested a review from cristidragomir97 May 13, 2024 06:54
Copy link

Memory usage change @ 37177c3

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/AllowDeepSleep
flash
% examples/AllowDeepSleep
RAM for global variables
% examples/DeepSleepLockDebug
flash
% examples/DeepSleepLockDebug
RAM for global variables
% examples/Standby
flash
% examples/Standby
RAM for global variables
%
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV
Board,examples/AllowDeepSleep<br>flash,%,examples/AllowDeepSleep<br>RAM for global variables,%,examples/DeepSleepLockDebug<br>flash,%,examples/DeepSleepLockDebug<br>RAM for global variables,%,examples/Standby<br>flash,%,examples/Standby<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@facchinm
Copy link

Would it be nice to add something like

#if defined(NO_ETHERNET_TURN_OFF)
#warning "Please check the documentation before using this functionality"
#endif

in case the user didn't read the info in advance?

@alrvid
Copy link
Member Author

alrvid commented May 13, 2024

Would it be nice to add something like

#if defined(NO_ETHERNET_TURN_OFF)
#warning "Please check the documentation before using this functionality"
#endif

in case the user didn't read the info in advance?

I just added that to the other open PR. Thanks! :-)

@alrvid alrvid merged commit 8d936ff into main May 13, 2024
8 checks passed
@alrvid alrvid deleted the alrvid-patch-1 branch May 13, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants