Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UNO R4 WiFi #305

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

facchinm
Copy link
Contributor

@facchinm facchinm commented Jul 3, 2023

Needs UNOR4USBBridge firmware >= 0.2.0

arduino/uno-r4-wifi-usb-bridge#5

@pennam

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 3, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the following:

  • Add the UNO R4 WiFi board to the "Compile Examples" GitHub Actions workflow.
  • Add UNO R4 WiFi to the list of supported boards in README.md
  • Add UNO R4 WiFi to the list of supported boards in the sentence field of the library.properties file.
  • Add the renesas_uno and renesas architectures to the architectures field of the library.properties file.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martino!

In combination with the following dependencies:

I was able to use the Peripheral/LED example on my UNO R4 WiFi and it worked exactly as expected.

I didn't do any testing of the library beyond that simple validation.

@per1234
Copy link
Contributor

per1234 commented Jul 16, 2023

Although it is already visible here from the linkback, I'll also add a comment here to highlight the presence of an issue report from a tester of the version of the library from this PR on the UNO R4 WiFi:

#309

Thanks for helping with the testing of this PR @MicheleMas!

@per1234
Copy link
Contributor

per1234 commented Jul 17, 2023

There is some feedback from a tester here:

https://forum.arduino.cc/t/arduinoble-doesnt-work-inside-library/1148979

Running the code on Nano 33 iot all the characteristics are present and everything works as expected:

[...]

but when it runs on Uno R4 WiFi the custom characteristics are not included in the service:

@per1234
Copy link
Contributor

per1234 commented Jul 20, 2023

There is a report from a tester of the version of the library from this PR on the UNO R4 WiFi here: #311

@ChavoDeLa
Copy link

advancement on my side in testing. code below fails when BUG_HERE =1, but succeeds when BUG_HERE=0

hope this helps, and thank you!

//NOTES AND README
  //code routine for beta testing ArduinoBLE on UNO R4 WIFI to pinpoint possible bug
  //WHERE BUG_HERE=0, code works. Where BUG_HERE=1 code fails


//INPUTS
  //Inclusions
    #include <ArduinoBLE.h>

  //BLE Services and Characteristics..
    BLEService VirtualPinService1("aa0d1e3d-72f7-4c20-88b9-bf497b559d94"); 

    BLEByteCharacteristic VP1("fe3fd2af-c3a0-400b-b794-46ef1eb6e197", BLEWrite);
    
    BLECharacteristic  VP2("309d2050-4576-4ffd-b134-1f896af3d6d7", BLERead | BLENotify ,8,(1==1));

    BLEByteCharacteristic VP3("b8a729ec-0811-4610-8600-7ab0be01bb82", BLERead | BLENotify);

    BLEByteCharacteristic VP4("faeb7c98-8464-4864-ad82-a5ea533cea51",  BLEWrite);

    BLEStringCharacteristic  VP5("ccd9be49-2e58-44f2-b335-73697e1a0625", BLERead | BLENotify , 30);

    BLEByteCharacteristic VP6("b8a729ec-0811-4610-8600-7ab0be01bb83", BLERead | BLENotify);

    unsigned int BUG_HERE = 1; 


  
void setup() {
  BLE.begin();
  BLE.setLocalName("BLE BETA TEST");
  VirtualPinService1.addCharacteristic(VP1);
  VirtualPinService1.addCharacteristic(VP2);
  VirtualPinService1.addCharacteristic(VP3);
  VirtualPinService1.addCharacteristic(VP4);
  VirtualPinService1.addCharacteristic(VP5);
  VirtualPinService1.addCharacteristic(VP6);
  BLE.addService(VirtualPinService1);
  BLE.advertise(); 
 }

void loop() {
    VirtualPinSync();
    BLE.poll();
  }
  
void VirtualPinSync(){   
   VP3.writeValue(BUG_HERE);                          
  }

@per1234
Copy link
Contributor

per1234 commented Aug 2, 2023

There is a report from a tester of the version of the library from this PR on the UNO R4 WiFi here:

https://forum.arduino.cc/t/uno-r4-wifi-disconnecting-reconnecting-continuously-when-running-sketch-w-led-matrix-and-arduinoble-libraries/1154103

They report that the BLE connection keeps disconnecting and reconnecting continuously when a call to ArduinoLEDMatrix::begin is added to the sketch.

@per1234
Copy link
Contributor

per1234 commented Aug 7, 2023

There is another report from a tester about problems with the use of this version of the library in combination with the "LED_Matrix" library on the UNO R4 WiFi board:

https://forum.arduino.cc/t/uno-r4-wifi-disconnecting-reconnecting-continuously-when-running-sketch-w-led-matrix-and-arduinoble-libraries/1154103/12

@KurtE
Copy link

KurtE commented Aug 9, 2023

Quick note: On the forum thread https://forum.arduino.cc/t/uno-r4-wifi-disconnecting-reconnecting-continuously-when-running-sketch-w-led-matrix-and-arduinoble-libraries/1154103/12

There was report of another library that when it was included, exhibited the same problem as the LED Matrix. But at least in the latter case, pulling in the updates to analog.cpp for the heap corruption bug, resolved that one. Not sure about the LED matrix one

@friyiajr
Copy link

Any updates on when this might get merged?

@facchinm facchinm changed the title wip: add support for UNO R4 WiFi Add support for UNO R4 WiFi Aug 30, 2023
@facchinm facchinm merged commit c05459e into arduino-libraries:master Aug 30, 2023
10 checks passed
@facchinm
Copy link
Contributor Author

@friyiajr published 😉 https://github.com/arduino-libraries/ArduinoBLE/releases/tag/1.3.6

@friyiajr
Copy link

@facchinm 🔥🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants