Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Fixed ARDUINO define #37

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Fixed ARDUINO define #37

merged 1 commit into from
Dec 19, 2017

Conversation

fraillt
Copy link

@fraillt fraillt commented Dec 19, 2017

ARDUINO define was not working properly between Arduino SDK versions 1.0.0 and 1.6.0.
This issue was caused by CMake line splitting, and new line was separated by multiple spaces, so in order to get correct define e.g.

-DARDUINO=105

it became

-DARDUINO="1          0            5"

See #35 for more info.

OR ...

Maybe show fatal error, if Arduino SKD is less than 1.6.0 ?

Copy link
Member

@MrPointer MrPointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a gut feeling it would cause issues eventually... Too bad the CI check didn't fail on this, it means that I was correct and we should also add configuration for older SDKs.
Thank you for fixing this!

@MrPointer MrPointer merged commit 50770f5 into arduino-cmake:master Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants