add presets: DRUIDS (Light Theme) and DRUIDS (Dark Theme)#16
Open
ivan wants to merge 1 commit intoardov:masterfrom
Open
add presets: DRUIDS (Light Theme) and DRUIDS (Dark Theme)#16ivan wants to merge 1 commit intoardov:masterfrom
ivan wants to merge 1 commit intoardov:masterfrom
Conversation
These are based on https://druids.datadoghq.com/foundations/color Because DRUIDS (Dark Theme) starts with the darkest colors at 100, I thought about re-ordering the tones so that they are 700..100 instead, but I noticed that Radix UI (Dark Theme) already exists as a preset with the tones ordered from darkest to lightest. This might preserve the color designer's intent, but it also makes it harder to compare visually against other presets. If "dark theme" presets really should be added as-is with darkest tones first, it might be useful to later have a "flip horizontally" button to make comparisons between color presets easier.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These presets are based on https://druids.datadoghq.com/foundations/color
side note:
Because DRUIDS (Dark Theme) starts with the darkest colors at 100, I thought about re-ordering the tones so that they are 700..100 instead, but I noticed that Radix UI (Dark Theme) already exists as a preset with the tones ordered from darkest to lightest. This might preserve the color designer's intent, but it also makes it harder to compare visually against other presets. If "dark theme" presets really should be added as-is with darkest tones first, it might be useful to later have a "flip horizontally" button to make comparisons between color presets easier.