Enable bugprone-switch-missing-default-case (halide#8048)

* Upgrade clang-format and clang-tidy to use LLVM 17 * trigger buildbots * trigger buildbots * trigger buildbots * trigger buildbots * Enable `bugprone-switch-missing-default-case` ...and fix existing warnings. * Update .clang-tidy * Update Parameter.cpp * Update .clang-tidy * Update .clang-tidy * Update .clang-tidy * Update .clang-tidy * Update CPlusPlusMangle.cpp
ardier · Mar 3, 2024 · 3a58321 · 3a58321
1 parent 5b03436
commit 3a58321
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 12 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -19,7 +19,7 @@ Checks: >
     bugprone-dangling-handle,
     bugprone-dynamic-static-initializers,
     -bugprone-easily-swappable-parameters,
-    -bugprone-empty-catch,  # TODO: consider enabling
+    -bugprone-empty-catch,
     -bugprone-exception-escape,
     bugprone-fold-init-type,
     bugprone-forward-declaration-namespace,
@@ -66,7 +66,7 @@ Checks: >
     bugprone-suspicious-semicolon,
     bugprone-suspicious-string-compare,
     bugprone-swapped-arguments,
-    -bugprone-switch-missing-default-case,  # TODO: consider enabling
+    bugprone-switch-missing-default-case,
     bugprone-terminating-continue,
     bugprone-throw-keyword-missing,
     bugprone-too-small-loop-variable,
@@ -93,7 +93,7 @@ Checks: >
     -misc-const-correctness,
     misc-definitions-in-headers,
     misc-header-include-cycle,
-    -misc-include-cleaner,  # TODO: consider enabling
+    -misc-include-cleaner,
     misc-misleading-bidirectional,
     misc-misleading-identifier,
     misc-misplaced-const,
@@ -128,7 +128,7 @@ Checks: >
     -modernize-replace-random-shuffle,
     -modernize-return-braced-init-list,
     -modernize-shrink-to-fit,
-    -modernize-type-traits,  # TODO: consider enabling
+    -modernize-type-traits,
     -modernize-unary-static-assert,
     -modernize-use-auto,
     modernize-use-bool-literals,

diff --git a/src/CPlusPlusMangle.cpp b/src/CPlusPlusMangle.cpp
@@ -246,9 +246,10 @@ MangledNamePart mangle_type(const Type &type, const Target &target, PreviousDecl
             return "H";
         case 64:
             return "_J";
+        default:
+            internal_error << "Unexpected integer size: " << type.bits() << ".\n";
+            return "";
         }
-        internal_error << "Unexpected integer size: " << type.bits() << ".\n";
-        return "";
     } else if (type.is_uint()) {
         switch (type.bits()) {
         case 1:
@@ -261,9 +262,10 @@ MangledNamePart mangle_type(const Type &type, const Target &target, PreviousDecl
             return "I";
         case 64:
             return "_K";
+        default:
+            internal_error << "Unexpected unsigned integer size: " << type.bits() << "\n";
+            return "";
         }
-        internal_error << "Unexpected unsigned integer size: " << type.bits() << "\n";
-        return "";
     } else if (type.is_float()) {
         if (type.bits() == 32) {
             return "M";
@@ -546,9 +548,10 @@ std::string mangle_type(const Type &type, const Target &target, PrevPrefixes &pr
             } else {
                 return "l";
             }
+        default:
+            internal_error << "Unexpected integer size: " << type.bits() << ".\n";
+            return "";
         }
-        internal_error << "Unexpected integer size: " << type.bits() << ".\n";
-        return "";
     } else if (type.is_uint()) {
         switch (type.bits()) {
         case 1:
@@ -571,9 +574,10 @@ std::string mangle_type(const Type &type, const Target &target, PrevPrefixes &pr
             } else {
                 return "m";
             }
+        default:
+            internal_error << "Unexpected unsigned integer size: " << type.bits() << "\n";
+            return "";
         }
-        internal_error << "Unexpected unsigned integer size: " << type.bits() << "\n";
-        return "";
     } else if (type.is_float()) {
         if (type.bits() == 32) {
             return "f";

diff --git a/src/CodeGen_OpenCL_Dev.cpp b/src/CodeGen_OpenCL_Dev.cpp
@@ -389,6 +389,9 @@ void CodeGen_OpenCL_Dev::CodeGen_OpenCL_C::visit(const Call *op) {
                 rhs << "(int4)(" << coord[0] << idx << ", " << coord[1] << idx
                     << ", " << coord[2] << idx << ", 0)).s0";
                 break;
+            default:
+                internal_error << "Unsupported dims";
+                break;
             }
             print_assignment(op->type.with_bits(32).with_lanes(1), rhs.str());
             results[i] = id;
@@ -448,6 +451,9 @@ void CodeGen_OpenCL_Dev::CodeGen_OpenCL_C::visit(const Call *op) {
                 write_image << "(int4)(" << coord[0] << idx << ", " << coord[1] << idx
                             << ", " << coord[2] << idx << ", 0)";
                 break;
+            default:
+                internal_error << "Unsupported dims";
+                break;
             }
             write_image << ", (" << print_type(value_type.with_bits(32).with_lanes(4))
                         << ")(" << value << idx << ", 0, 0, 0));\n";

diff --git a/src/HexagonOptimize.cpp b/src/HexagonOptimize.cpp
@@ -91,6 +91,8 @@ string type_suffix(Type type, bool signed_variants) {
             return prefix + "h";
         case 32:
             return prefix + "w";
+        default:
+            break;
         }
     } else if (type.is_uint()) {
         switch (type.bits()) {
@@ -100,6 +102,8 @@ string type_suffix(Type type, bool signed_variants) {
             return prefix + "uh";
         case 32:
             return prefix + "uw";
+        default:
+            break;
         }
     }
     internal_error << "Unsupported HVX type: " << type << "\n";

diff --git a/src/Parameter.cpp b/src/Parameter.cpp
@@ -142,6 +142,8 @@ Expr Parameter::scalar_expr() const {
             return Expr(sv.u.f32);
         case 64:
             return Expr(sv.u.f64);
+        default:
+            break;
         }
     } else if (t.is_int()) {
         switch (t.bits()) {
@@ -153,6 +155,8 @@ Expr Parameter::scalar_expr() const {
             return Expr(sv.u.i32);
         case 64:
             return Expr(sv.u.i64);
+        default:
+            break;
         }
     } else if (t.is_uint()) {
         switch (t.bits()) {
@@ -166,12 +170,16 @@ Expr Parameter::scalar_expr() const {
             return Expr(sv.u.u32);
         case 64:
             return Expr(sv.u.u64);
+        default:
+            break;
         }
     } else if (t.is_handle()) {
         // handles are always uint64 internally.
         switch (t.bits()) {
         case 64:
             return Expr(sv.u.u64);
+        default:
+            break;
         }
     }
     internal_error << "Unsupported type " << t << " in scalar_expr\n";

diff --git a/src/runtime/openglcompute.cpp b/src/runtime/openglcompute.cpp
@@ -88,6 +88,8 @@ WEAK const char *gl_error_name(int32_t err) {
     case 0x8031:
         return "GL_TABLE_TOO_LARGE";
         break;
+    default:
+        break;
     }
     return "<unknown GL error>";
 }

diff --git a/tools/halide_image_io.h b/tools/halide_image_io.h
@@ -1455,6 +1455,9 @@ bool load_mat(const std::string &filename, ImageType *im) {
     case miDOUBLE:
         type = halide_type_of<double>();
         break;
+    default:
+        check(false, "Unknown header");
+        return false;
     }
 
     *im = ImageType(type, extents);