Skip to content

Conversation

@ardatan
Copy link
Owner

@ardatan ardatan commented Aug 2, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: b413f77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/delegate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/delegate 10.0.2-alpha-20230809112735-b413f771 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 226       ✗ 0  
     data_received..................: 26 MB   2.6 MB/s
     data_sent......................: 97 kB   9.6 kB/s
     http_req_blocked...............: avg=25.44µs  min=2.7µs   med=3.4µs   max=2.46ms   p(90)=4.58µs   p(95)=5.33µs  
     http_req_connecting............: avg=21.08µs  min=0s      med=0s      max=2.38ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=82.59ms  min=68.39ms med=77.94ms max=212.47ms p(90)=93.65ms  p(95)=125.36ms
       { expected_response:true }...: avg=82.59ms  min=68.39ms med=77.94ms max=212.47ms p(90)=93.65ms  p(95)=125.36ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 113
     http_req_receiving.............: avg=265.41µs min=146.3µs med=169.7µs max=6.63ms   p(90)=318.56µs p(95)=325.32µs
     http_req_sending...............: avg=114.61µs min=17.7µs  med=25.8µs  max=3.94ms   p(90)=39.45µs  p(95)=59.76µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=82.21ms  min=68.18ms med=77.69ms max=212.06ms p(90)=93.33ms  p(95)=125.08ms
     http_reqs......................: 113     11.257204/s
     iteration_duration.............: avg=88.77ms  min=73.42ms med=83.61ms max=220.28ms p(90)=110.97ms p(95)=131.14ms
     iterations.....................: 113     11.257204/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

💻 Website Preview

The latest changes are available as preview in: https://b978b142.graphql-tools.pages.dev

@ardatan ardatan marked this pull request as ready for review August 9, 2023 10:51
const existingPropValue = object[responseKey];
const sourcePropValue = resolverResult[responseKey];
if (sourcePropValue != null || existingPropValue == null) {
object[responseKey] = sourcePropValue;

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1). This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](2). This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](3). This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](4). This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](5). This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](6).
@ardatan ardatan merged commit cfd4782 into master Aug 9, 2023
@ardatan ardatan deleted the batching-optimizations-more branch August 9, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants