Add Map Extension Method to Support Mapping from Result<T> to Result #213
Conversation
| case ResultStatus.Conflict: return result.Errors.Any() | ||
| ? Result.Conflict(result.Errors.ToArray()) | ||
| : Result.Conflict(); | ||
| case ResultStatus.CriticalError: return Result.CriticalError(result.Errors.ToArray()); |
There was a problem hiding this comment.
Does this need the correlation id as well?
There was a problem hiding this comment.
CriticalError accepts a string[], so we cannot pass in the correlation id. See https://github.com/ardalis/Result/blob/main/src/Ardalis.Result/Result.cs#L223.
While Error accepts an ErrorList object that contains correlation id. See https://github.com/ardalis/Result/blob/main/src/Ardalis.Result/Result.cs#L123-L127
There was a problem hiding this comment.
I believe we're in a bit of a transition phase to using the ErrorList class in more places but ideally we'd use the constructors that accept a CorrelationId wherever possible.
There was a problem hiding this comment.
I have verified the CorrelationId property is propagated through the constructors where it is available. We can open another issue to add CorrelationId to the remaining constructors and then update these helper methods as needed.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
See #212