Skip to content

Performance Improvements: NullOrEmpty check on IEnumerable<T> #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ardalis merged 3 commits into from
Jan 23, 2024
Merged

Performance Improvements: NullOrEmpty check on IEnumerable<T> #328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beb32f5
Performance Improvements: NullOrEmpty check on IEnumerable<T>
mjebrahimi Dec 20, 2023
de0a430
Merge branch 'main' into main
ardalis Jan 18, 2024
07e7d4e
Merge branch 'main' into main
ardalis Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/GuardClauses/GuardAgainstNullExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,12 @@ public static IEnumerable<T> NullOrEmpty<T>(this IGuardClause guardClause,
#endif
{
Guard.Against.Null(input, parameterName, message);
if (!input.Any())

if (input is Array and { Length: 0 } //Try checking first with pattern matching because it's faster than TryGetNonEnumeratedCount on Array
#if NET6_0_OR_GREATER
|| (input.TryGetNonEnumeratedCount(out var count) && count == 0)
#endif
|| !input.Any())
{
throw new ArgumentException(message ?? $"Required input {parameterName} was empty.", parameterName);
}
Expand Down