Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ADR for Dependency Injection Framework Update #829 #840

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

Zaki2409
Copy link
Contributor

This PR addresses issue #829 by formalizing the decision to improve dependency management and simplify the project's structure.

This pull request introduces Architecture Decision Records (ADRs) to document significant architectural choices in the project. Specifically, it includes an ADR detailing the decision to replace Autofac with .NET's native Dependency Injection (DI) framework, following feedback from the community (refer to issue #649).

Screenshot 2024-10-12 223456

Key Changes:

  1. Added an ADR to explain the rationale behind the move from Autofac to .NET DI.
  2. Incorporated community feedback into the decision-making process.
  3. Established a framework for future ADRs to ensure architectural decisions are documented and transparent.

Screenshot (33)
Screenshot (34)

@Zaki2409 Zaki2409 changed the title Add ADR for Dependency Injection Framework Update #829 Added ADR for Dependency Injection Framework Update #829 Oct 12, 2024
@lukehammer
Copy link

I reviewed this or and found it to be good

@Zaki2409
Copy link
Contributor Author

Thanks for checking it out! I'm glad you found it to be good.

@ardalis ardalis merged commit 5997039 into ardalis:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants