chore(general): remove deprecated general 'route message' with string #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnmoreels
added
the
area:message-processing
✅ Deploy Preview for arcus-messaging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
97 tasks
fgheysels
reviewed
May 30, 2025
| @@ -10,24 +8,5 @@ namespace Arcus.Messaging.Abstractions.MessageHandling | |||
| [Obsolete("Will be removed in v3.0 as only concrete implementations of message routing will be supported from now on")] | |||
| public interface IMessageRouter | |||
There was a problem hiding this comment.
Why don't we remove the interface entirely ?
There was a problem hiding this comment.
Step by step, keeping changes separated to reduce ripple effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
IMessageRouter.RouteMessageAsyncmethod that takes in astringmessage in favor of concrete type implementations in message pump/router solutions.