Skip to content

Conversation

@lukinovec
Copy link
Contributor

@lukinovec lukinovec requested a review from stancl September 2, 2022 10:55
@lukinovec lukinovec changed the title Add ScoutTenancyBootstrapper [4.x] Add ScoutTenancyBootstrapper Sep 2, 2022
@stancl
Copy link
Member

stancl commented Sep 2, 2022

Great implementation, making a minor change and merging this straight away 👍🏻

@stancl
Copy link
Member

stancl commented Sep 2, 2022

Added a method to make customizing this easy — now people can extend the bootstrapper and just override that one method to customize how the prefixes are generated.

Can you test this code locally in your Scout repo to see if it works well? And update the docs PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #936 (e2ee9ec) into master (62d19c5) will decrease coverage by 0.80%.
The diff coverage is 23.07%.

❗ Current head e2ee9ec differs from pull request most recent head a0f22c4. Consider uploading reports for the commit a0f22c4 to get more accurate results

@@             Coverage Diff              @@
##             master     #936      +/-   ##
============================================
- Coverage     88.01%   87.20%   -0.81%     
- Complexity      400      405       +5     
============================================
  Files           110      111       +1     
  Lines          1110     1118       +8     
============================================
- Hits            977      975       -2     
- Misses          133      143      +10     
Impacted Files Coverage Δ
...trappers/Integrations/ScoutTenancyBootstrapper.php 0.00% <0.00%> (ø)
src/Features/CrossDomainRedirect.php 100.00% <100.00%> (ø)
src/Tenancy.php 92.45% <100.00%> (ø)
src/helpers.php 55.55% <100.00%> (-2.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stancl stancl merged commit f83504a into master Sep 2, 2022
@stancl stancl deleted the add-scout-tenancy-bootstrapper branch September 2, 2022 15:24
@lukinovec
Copy link
Contributor Author

Can you test this code locally in your Scout repo to see if it works well? And update the docs PR.

Works fine 👍

@wilsenhc
Copy link
Contributor

@lukinovec @stancl is this something that could be back-ported or used with Tenancy v3? Have you tried it out?

@stancl
Copy link
Member

stancl commented Mar 28, 2023

There's nothing v4-specific in the bootstrapper I think. But we won't be adding it to v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants