-
-
Notifications
You must be signed in to change notification settings - Fork 483
[4.x] Add ScoutTenancyBootstrapper #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great implementation, making a minor change and merging this straight away 👍🏻 |
|
Added a method to make customizing this easy — now people can extend the bootstrapper and just override that one method to customize how the prefixes are generated. Can you test this code locally in your Scout repo to see if it works well? And update the docs PR. |
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
============================================
- Coverage 88.01% 87.20% -0.81%
- Complexity 400 405 +5
============================================
Files 110 111 +1
Lines 1110 1118 +8
============================================
- Hits 977 975 -2
- Misses 133 143 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Works fine 👍 |
|
@lukinovec @stancl is this something that could be back-ported or used with Tenancy v3? Have you tried it out? |
|
There's nothing v4-specific in the bootstrapper I think. But we won't be adding it to v3 |
Related PR: stancl/tenancy-docs#193