Skip to content

Cache property of graphics_devices #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h8d13 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cache property of graphics_devices #4007

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b205a0
On horrible hardware this makes it so that the "Graphics drivers" sec…
h8d13 Dec 17, 2025
692fecc
Init after logs
h8d13 Dec 17, 2025
4c5fb53
This cache the property of graphics drivers properly.
h8d13 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions archinstall/lib/hardware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,18 @@ def loaded_modules(self) -> list[str]:

return modules

@cached_property
def graphics_devices(self) -> dict[str, str]:
"""
Returns detected graphics devices (cached)
"""
cards: dict[str, str] = {}
for line in SysCommand('lspci'):
if b' VGA ' in line or b' 3D ' in line:
_, identifier = line.split(b': ', 1)
cards[identifier.strip().decode('UTF-8')] = str(line)
return cards


_sys_info = _SysInfo()

Expand All @@ -209,24 +221,19 @@ def has_uefi() -> bool:

@staticmethod
def _graphics_devices() -> dict[str, str]:
cards: dict[str, str] = {}
for line in SysCommand('lspci'):
if b' VGA ' in line or b' 3D ' in line:
_, identifier = line.split(b': ', 1)
cards[identifier.strip().decode('UTF-8')] = str(line)
return cards
return _sys_info.graphics_devices

@staticmethod
def has_nvidia_graphics() -> bool:
return any('nvidia' in x.lower() for x in SysInfo._graphics_devices())
return any('nvidia' in x.lower() for x in _sys_info.graphics_devices)

@staticmethod
def has_amd_graphics() -> bool:
return any('amd' in x.lower() for x in SysInfo._graphics_devices())
return any('amd' in x.lower() for x in _sys_info.graphics_devices)

@staticmethod
def has_intel_graphics() -> bool:
return any('intel' in x.lower() for x in SysInfo._graphics_devices())
return any('intel' in x.lower() for x in _sys_info.graphics_devices)

@staticmethod
def cpu_vendor() -> CpuVendor | None:
Expand Down