Skip to content

Conversation

@svartkanin
Copy link
Collaborator

@svartkanin svartkanin commented Dec 15, 2025

This PR migrates all menus to the textual framework introduced with #3879.

The current implementation is creating a new textual app and destroying it with every menu/submenu which is not how it is supposed to be.
The final version will use a single app instance and switch between screens smoothly but to keep things (somewhat) manageable, that change will be done in a follow-up PR in which the code will be moved to an async model (see the wifi screen that is already doing that https://github.com/svartkanin/archinstall/blob/fdb002fa31471d86e1d5e99bc6ec4c21ba1a3b15/archinstall/lib/network/wifi_handler.py?plain=1#L1)

I have tested everything somewhat but not extensively yet. I have opened the PR regardles for now in case someone wants to have a go at it and provide some feedback.

[X] Test everything thoroughly

@svartkanin svartkanin requested a review from Torxed as a code owner December 15, 2025 11:19
@h8d13
Copy link
Contributor

h8d13 commented Dec 16, 2025

Looks cool @svartkanin :D

Tested a little bit, I came across was f1 help screen crashed and user setup screen was missing should user be sudo text and preview for this has 2 screens

The rest seems like it's already fully functional (considering what you said about the flicker), like how you can use cursor, very bamby friendly 🖱️

Would be cool to add globally visible hints for esc go back ctrl+c clear a field enter : confirm space/tab : select multiple / : search

Then more specific go in help screen ?

@svartkanin
Copy link
Collaborator Author

Thanks @h8d13 for testing!

  • Fixed the select sudo header
  • Can you share a screenshot or error that you get for the f1 help screen crash? I cannot reproduce that
  • Not sure what you mean with preview for this has 2 screens

Daniel Girtler added 2 commits December 17, 2025 16:59
@h8d13
Copy link
Contributor

h8d13 commented Dec 17, 2025

My bad was missing pacman -S python-linkify-it-py for f1 crash.

For my other point sorry was not clear I meant when you are in the submenu
image

It shows you the overview again but the Esc key doesn't register to go back to main menu, same when you are here: (Need to use arrows menu 2x instead of pressing Esc to go back like in the rest, applies to other submenus too, would be nice to have kb handling)

image

Let me know if you have anything specific, you need tested :) Or need help with something !

@svartkanin
Copy link
Collaborator Author

Most submenus (The ones with a Back option) don't have a support for Esc as that's reserved for leaf selection menus. That behavior exists already

@h8d13
Copy link
Contributor

h8d13 commented Dec 17, 2025

Yeah I thought it would be a good thing if it also worked in these menus reduce keys needed to get around

Had another question, I saw that runners were going to be more restrictive (and paid) for github and always thought the ISO one takes a while (seems unnecessary for smaller changes) .

Is there anyway we can disable it unless on major releases/needed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants