Enable unreachable code checks in lib/ with mypy#3521
Merged
svartkanin merged 1 commit intoarchlinux:masterfrom May 28, 2025
Merged
Enable unreachable code checks in lib/ with mypy#3521svartkanin merged 1 commit intoarchlinux:masterfrom
svartkanin merged 1 commit intoarchlinux:masterfrom
Conversation
correctmost
commented
May 28, 2025
| return asdict(o) | ||
| else: | ||
| return o.__dict__ | ||
| return o.__dict__ # type: ignore[unreachable] |
Contributor
Author
There was a problem hiding this comment.
I added an ignore for now because I'm not sure if this line can be reached.
This function has other typing issues, so the ignore can be revisited after the other issues are addressed.
svartkanin
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
With this PR, unreachable checks will now be performed on the entire codebase.
Tests and Checks