Fix 1716 - Retry on mirror list fetching #2736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the phone so hard to search, but didn't we already have a And if my memory servers, we also discussed adding retry would cause delays to mirror ranking? Maybe we need to curate a list of errors like the related one in the issue that are retry worthy? |
|
Right, this change is in the generic networking function used by the mirror list. Maybe it's better to attempt the retry on the consumer based on certain errors |
|
@Torxed I have moved the retry local into the mirror logic instead and if that fails it should fallback now to the local mirror list |
svartkanin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2716 by adding a retry for http calls and provide more logging information to make debugging easier