Increase coverage for ComputeImageSize. #45

[greebie]

** Increases coverage for ComputeImage Size #45

---

GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

#45

What does this Pull Request do?

A brief description of what the intended result of the Pull Request (PR) will be, what problem it solves, technical details, and any possible side effects.

Increase test coverage for ComputeImageSize

How should this be tested?

Codecov + Travis.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties.

Thanks in advance for your help with the Archives Unleashed Toolkit!

[greebie]

Hi @ruebot I would not accept this one until it has 100% coverage. It technically does work, but I cannot get it to create an exception at the right spot.

[ruebot]

@greebie cool. let's see what the report says, and I'll see if I can do anything to help. Worst case we merge, and leave the ticket open, and come back around to it at a later date.

[greebie]

Okay - I still get NullPointerException on ComputeImageSize(null) but when I try to catch the error, it doesn't bother. 🤷‍♂️

[codecov]

Codecov Report

Merging #89 into master will increase coverage by 1.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   48.59%   49.81%   +1.21%     
==========================================
  Files          41       41              
  Lines         821      821              
  Branches      147      147              
==========================================
+ Hits          399      409      +10     
+ Misses        381      371      -10     
  Partials       41       41

Impacted Files	Coverage Δ
...vesunleashed/spark/matchbox/ComputeImageSize.scala	100% <100%> (+100%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cd498...e596143. Read the comment docs.

[greebie]

Okay figured out how to get it to 100%. The script elected to return (0,0) rather than throwing exception.