-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup for Serializable APIs on DataFrames #389
Merged
ruebot
merged 12 commits into
archivesunleashed:master
from
SinghGursimran:Serializable-APIs
Dec 17, 2019
Merged
Setup for Serializable APIs on DataFrames #389
ruebot
merged 12 commits into
archivesunleashed:master
from
SinghGursimran:Serializable-APIs
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 76.87% 77.03% +0.15%
==========================================
Files 40 40
Lines 1466 1476 +10
Branches 274 274
==========================================
+ Hits 1127 1137 +10
Misses 217 217
Partials 122 122 |
@SinghGursimran got tests? 😃 |
oh! sorry forgot about that. I will add it now. |
Looks good!
|
ruebot
approved these changes
Dec 17, 2019
Once @ianmilligan1 merges #388, I'll get this merged. Should be here in a bit, or later this afternoon. |
I think we're good on docs for this, since we already have
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for Serializable APIs on DataFrames
#223
For Testing:
Since it is the migration of RDD's functionality to DF, final answer should be the same as given by the following transformation on RDD.