-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup: ArchiveRecord + impl moved into same Scala file #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about blank line. Other than that, looks good and I'll merge when TravisCI turns green.
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=========================================
+ Coverage 59.87% 60.07% +0.2%
=========================================
Files 39 39
Lines 770 774 +4
Branches 137 137
=========================================
+ Hits 461 465 +4
Misses 268 268
Partials 41 41
Continue to review full report at Codecov.
|
@@ -17,20 +17,111 @@ | |||
|
|||
package io.archivesunleashed | |||
|
|||
import java.text.SimpleDateFormat | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. My comment from earlier is missing.
...do we need this blank line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find Scala style guides that dictate import, but for Java, it is common to have groups separated by blank lines, see http://checkstyle.sourceforge.net/config_imports.html
To quote, one common approach is:
- group of static imports is on the top
- groups of non-static imports: "java" and "javax" packages first, then "org" and then all other imports
- imports will be sorted in the groups
- groups are separated by, at least, one blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. That make sense. Let's just proceed with using that approach.
As an aside, I had the same problem trying to find guidelines on Scala style imports, and ended up doing it alphabetically, and soon realized order does matter at times. 🤷♂️
What does this Pull Request do?
Cleans up code for
ArchiveRecord
and adds documentation.else
clause.