Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many JUNITs #152

Merged
merged 6 commits into from
Dec 11, 2017
Merged

Too many JUNITs #152

merged 6 commits into from
Dec 11, 2017

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Dec 11, 2017

Follow-up to #150

@ianmilligan1

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will merge once tests pass!

@codecov
Copy link

codecov bot commented Dec 11, 2017

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   67.95%   67.95%           
=======================================
  Files          38       38           
  Lines         774      774           
  Branches      143      143           
=======================================
  Hits          526      526           
  Misses        199      199           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb23d8...a71c920. Read the comment docs.

@ruebot
Copy link
Member Author

ruebot commented Dec 11, 2017

@ianmilligan1 can you merge?

@ianmilligan1 ianmilligan1 merged commit 57acd0b into archivesunleashed:master Dec 11, 2017
@ianmilligan1
Copy link
Member

Aye (sorry for delay, daycare ended!)

@ruebot ruebot deleted the packages branch August 10, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants