Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple Formatter Test Improvement #145

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Tuple Formatter Test Improvement #145

merged 2 commits into from
Dec 8, 2017

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Dec 8, 2017

  • Include test for flatten.default
  • Remove duplicate call to FunSuite in ExtractPopularImagesTest

The title of this pull-request should be a brief description of what the pull-request fixes/improves/changes. Ideally 50 characters or less.


GitHub issue(s):

#59

What does this Pull Request do?

Same as above.

How should this be tested?

Codecov.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Thanks in advance for your help with the Archives Unleashed Toolkit!

- Remove duplicate call to FunSuite in ExtractPopularImagesTest
@greebie
Copy link
Contributor Author

greebie commented Dec 8, 2017

This may not improve coverage, but is good to submit because it removes a duplicate import.

@codecov
Copy link

codecov bot commented Dec 8, 2017

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files          38       38           
  Lines         775      775           
  Branches      143      143           
=======================================
  Hits          525      525           
  Misses        201      201           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b5d26...705fdea. Read the comment docs.

@ruebot ruebot merged commit aaad971 into master Dec 8, 2017
@ianmilligan1 ianmilligan1 deleted the Issue-59 branch December 11, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants