Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need pythonconverters/ArcRecordConverter.scala? If so, tests. If not, delete it. #65

Closed
ruebot opened this issue Oct 2, 2017 · 1 comment
Closed

Do we need pythonconverters/ArcRecordConverter.scala? If so, tests. If not, delete it. #65

ruebot opened this issue Oct 2, 2017 · 1 comment
Assignees
@ruebot
Labels
tests

Comments

@ruebot
Copy link
Member

ruebot commented Oct 2, 2017

There is no test coverage on ArcRecordConverter.scala.
@ruebot ruebot added the tests label Oct 2, 2017
@ruebot ruebot self-assigned this Oct 2, 2017
@ruebot
Copy link
Member Author

ruebot commented Oct 2, 2017

Doesn't look like we need this file:

$ grep -R "ArcRecordWritableToUrlConverter" .
./scala/io/archivesunleashed/spark/pythonconverters/ArcRecordConverter.scala:class ArcRecordWritableToUrlConverter extends Converter[Any, String] {

I'll delete it, and put in a PR.

ruebot added a commit that referenced this issue Oct 2, 2017
@ruebot
Remove unused file; resolves #65.
421b541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruebot