You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ImageInformationExtractor.scala is tied to the ImageInformationExtractorspark-submit job
ExtractImageDetailsDF is standalone, and is not documented anywhere other than doc comments.
The big difference between the two is ExtractImageDetailsDF includes the bytes column.
I propose we remove this now prior to the 1.0.0 release, and in the future if there is a demand for binary extract jobs, we can add them. Or just add a flag to the current jobs to include the bytes column 😉
@lintool@ianmilligan1 let me know if there is any strong disagreement with removing this.
The text was updated successfully, but these errors were encountered:
ExtractImageDetailsDF.scala came in while we were working on #223. At the time it was needed, but now it is basically redundant with ImageInformationExtractor.scala.
ImageInformationExtractor.scala
is tied to theImageInformationExtractor
spark-submit
jobExtractImageDetailsDF
is standalone, and is not documented anywhere other than doc comments.The big difference between the two is
ExtractImageDetailsDF
includes the bytes column.I propose we remove this now prior to the 1.0.0 release, and in the future if there is a demand for binary extract jobs, we can add them. Or just add a flag to the current jobs to include the bytes column 😉
@lintool @ianmilligan1 let me know if there is any strong disagreement with removing this.
The text was updated successfully, but these errors were encountered: