Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text column to imageGraph (imageLinks) #420

Closed
ruebot opened this issue Feb 10, 2020 · 2 comments
Closed

Add alt text column to imageGraph (imageLinks) #420

ruebot opened this issue Feb 10, 2020 · 2 comments
Assignees
@ruebot
Labels
DataFrames enhancement Scala

Comments

@ruebot
Copy link
Member

ruebot commented Feb 10, 2020

Let's add a new column to .imageGraph(); the text of the alt attribute if it exists in an image tag.
@lintool
Copy link
Member

lintool commented Feb 10, 2020

.imageGraph() or .imagegraph()? The latter would be consistent with .webgraph(). Or alternatively, rename .webgraph() to .linkgraph() and you get a nice {image, link} symmetry.

@lintool lintool mentioned this issue Feb 10, 2020
Merged
@ianmilligan1
Copy link
Member

FWIW I like .imagegraph()

@ruebot ruebot self-assigned this Feb 10, 2020
ruebot added a commit that referenced this issue Feb 10, 2020
@ruebot
Add img alt text to imagegraph(); resolves #420.
6f5c81c 
- Update ExtractImageLinksRDD to grab alt text
- Add alt_text column to imagegraph
- Update tests
@ruebot ruebot mentioned this issue Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
DataFrames enhancement Scala
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ruebot @lintool @ianmilligan1