Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before the next release, make sure docker-aut builds on master... or make sure --packages works #227

Closed
ruebot opened this issue May 17, 2018 · 5 comments
Assignees

Comments

@ruebot
Copy link
Member

ruebot commented May 17, 2018

Two parts to this issue:

  1. As we add and remove dependencies to our pom.xml, this will break --packages on master. I'm comfortable with this happening on master, since we're actively adding to it. But, once we get close to a release we should make it builds fine. A sane test environment to do this with what is currently docker-aut master. I can add this to the release documentation as a prerequisite.

  2. We should change master to dev on docker-aut, and no longer make it the default branch. @lintool, @ianmilligan1 are you fine with me making the latest release the default branch, and also setting it as the default branch on docker-hub?

I'd create the issue over there, but these two items are closely intertwined.

@ruebot ruebot self-assigned this May 17, 2018
@ruebot
Copy link
Member Author

ruebot commented May 17, 2018

Another option is to add a script to the TravisCI build to make sure it always works on master 😄

@ruebot
Copy link
Member Author

ruebot commented May 17, 2018

...err, maybe not since it would just sit at the scala prompt if it was successful. 🤔

@ianmilligan1
Copy link
Member

We should change master to dev on docker-aut, and no longer make it the default branch. @lintool, @ianmilligan1 are you fine with me making the latest release the default branch, and also setting it as the default branch on docker-hub?

Fine with me!

@ianmilligan1
Copy link
Member

Once the docker-aut testing is added to the release page as a pre-requisite, now that the default branch on docker-aut is set to latest release, this issue is probably closable?

I would add to the release page myself but I was unsure the right place to put language in.

@ruebot
Copy link
Member Author

ruebot commented Jul 2, 2018

Done.

@ruebot ruebot closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants