Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary buffer copying #18

Closed
ruebot opened this issue Jul 10, 2017 · 4 comments
Closed

Unnecessary buffer copying #18

ruebot opened this issue Jul 10, 2017 · 4 comments
Labels
enhancement RA-Task

Comments

@ruebot
Copy link
Member

ruebot commented Jul 10, 2017 •
edited
Loading

From TODO in src/main/java/io/archivesunleashed/data/WarcRecordUtils.java and src/main/java/io/archivesunleashed/data/ArcRecordUtils.java that will be removed with the resolution of #3:

These methods work fine, but there's a lot of unnecessary buffer copying, which is terrible from a performance perspective.
@ianmilligan1
Copy link
Member

Do we see ourselves as tackling this?

@ruebot
Copy link
Member Author

ruebot commented Jan 8, 2018

I think we need to leave this open, if that is what you're asking.

@ruebot ruebot added the RA-Task label Feb 5, 2018
@ruebot
Copy link
Member Author

ruebot commented Aug 21, 2019

@lintool should be the decider on closing this or leaving it open, since it looks like he added it https://github.com/lintool/warcbase/blame/cab311ed8b0bceb666865fa76dd3bc5a86402e13/warcbase-core/src/main/java/org/warcbase/data/WarcRecordUtils.java#L40

@lintool
Copy link
Member

lintool commented Aug 21, 2019

Yes, I think we should leave this open. Something we should tackle when (if...) we have cycles...

ruebot added a commit that referenced this issue May 18, 2022
@ruebot
Sparkling integration updates.
8058484 
* fix discardDate issue
* update tests for #494
* add test for #493
* add test for #532
* move issue specific tests to their own directory
* add copyright statement to SparklingArchiveRecord
* move webarchive-commons back to 1.1.9
* resolves #532
* resolves #494
* resolves #493
* resolves #492
* resolves #317
* resolves #260
* resolves #182
* resolves #76
* resolves #74
* resolves #73
* resolves #23
* resolves #18
@ruebot ruebot mentioned this issue May 18, 2022
Merged
@ruebot ruebot closed this as completed in c8fa256 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement RA-Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ruebot @lintool @ianmilligan1 and others