Repository navigation
fix: report errors for missing directory sources - #869
Open
vhinayindia wants to merge 1 commit into
Open
vhinayindia wants to merge 1 commit into
vhinayindia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
directory()receives a source path that does not exist,readdir-globtreats the missing root as an empty result. Archiver can therefore finish without reporting the filesystem error.Check the source path before starting traversal. If it cannot be read, balance the pending traversal, abort the incomplete archive, emit the filesystem error, and reject
finalize()with the same error. A file path still reachesreaddir-globand reportsENOTDIR.Fixes #488.
Tests:
npm test(41 passing, 1 pending);npx prettier --check lib/core.js test/archiver.js.