Fix BiomeModifications failing on NeoForge - #730
Merged
Conversation
Registered biome modifiers failed to be discovered previously on NeoForge
|
|
st0x0ef
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the missing
impl.jsonbiome modifier data file to the datapack of theneoforgemodule.Because this file was missing, all programmatic biome modifications via
BiomeModifications#addPropertieswere silently ignored on NeoForge. I basically just copied it over from theforgemodule which needed the same file for data-driven biome modifications to work. It seems copying the file over was simply overlooked :)I've confirmed biome modifications to be working in the NeoForge test mod after adding this file. Before this change, the passed BiConsumer was never invoked.
All the NeoForge modules have this problem up to and including the most recent version--if that's welcome, I can open PRs for the other branches as well :)