Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last oracle chain loaded in mem table loader init #634

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 15, 2022

Description

When a node restart, it loads the past oracle summary in memory, but it do not load the last oracle transaction.
In some case the next self repair after the bootstrap may failed caused by an invalid_transaction_fee error.
So, during init Oracle Mem Table Loader also load the last oracle chain transactions

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

To reproduce the error:

  • start 3 node and wait them to be authorized
  • after an oracle summary, wait for the next oracle transaction (normally coming just after summary)
  • stop a node
  • send a transfer transaction
  • restart the node after other set it as unavailable

On the next self repair, the restarted node should have a invalid transaction fee error.

With the fix the error do not happen anymore

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working bootstrap labels Oct 15, 2022
@Neylix Neylix force-pushed the Fix-oracle-mem-table-loader branch from ad91f88 to 1f08cc5 Compare October 17, 2022 08:22
@Neylix Neylix force-pushed the Fix-oracle-mem-table-loader branch from 1f08cc5 to 190b9a7 Compare October 17, 2022 08:39
@samuelmanzanera samuelmanzanera merged commit 99ea2e9 into archethic-foundation:develop Oct 17, 2022
@Neylix Neylix deleted the Fix-oracle-mem-table-loader branch October 18, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants