Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selfsigned certificate by default in prod config #632

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 15, 2022

Description

By default there is no certificate for https in prod config. But without certificate, the https endpoint is not launched and so we cannot resolve request for aeweb redirection with dnslink.

To enable this functionnality, a self signed certificate is configured by default so the https endpoint is started and the node can serve aeweb website with certificate and https encryption

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added the networking Involve networking label Oct 15, 2022
lib/archethic_web/domain.ex Outdated Show resolved Hide resolved
This permit to enable the https port on node startup
@Neylix Neylix force-pushed the Add-self-signed-certificate-in-prod branch from b09ca19 to cc14359 Compare October 15, 2022 16:17
@samuelmanzanera samuelmanzanera merged commit 8d6f9f7 into archethic-foundation:develop Oct 17, 2022
@Neylix Neylix deleted the Add-self-signed-certificate-in-prod branch October 17, 2022 07:42
@samuelmanzanera samuelmanzanera added the bug Something isn't working label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working networking Involve networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants