Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sobelow for static analysis in dev and ci/cd #631

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

wicliff
Copy link
Contributor

@wicliff wicliff commented Oct 13, 2022

Description

Adds sobelow for static analysis of the code

Refer: https://github.com/nccgroup/sobelow

Fixes #593

Type of change

  • Changes in dependencies
  • mix task changes - mix dev.checks & mix dev.pchecks
  • Git hook for pre_push will now run sobelow checks
  • GitHub Actions run sobelow checks

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran it locally and on the CI.

Sobelow checks are run and the report is shown.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added testing Improve testing external contribution Contribution by non core team quality Improve code quality labels Oct 14, 2022
@Neylix Neylix changed the base branch from master to develop October 14, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contribution Contribution by non core team quality Improve code quality testing Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Sobelow for security static analysis
3 participants